diff options
| author |   djm <djm@openbsd.org> | 2014-02-02 03:44:31 +0000 |
|---|---|---|
| committer | djm <djm@openbsd.org> | 2014-02-02 03:44:31 +0000 |
| commit | c671dcf14e079a1b6525a1f57647ad96afd7b3f0 (patch) | |
| tree | 2c346b9f1e36ecacfa7b237ca21c54a6daf3a369 /usr.bin/ssh/ssh-ed25519.c | |
| parent | drm/i915/dp: increase i2c-over-aux retry interval on AUX DEFER (diff) | |
| download | wireguard-openbsd-c671dcf14e079a1b6525a1f57647ad96afd7b3f0.tar.xz wireguard-openbsd-c671dcf14e079a1b6525a1f57647ad96afd7b3f0.zip | |
convert memset of potentially-private data to explicit_bzero()
Diffstat (limited to 'usr.bin/ssh/ssh-ed25519.c')
| -rw-r--r-- | usr.bin/ssh/ssh-ed25519.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/usr.bin/ssh/ssh-ed25519.c b/usr.bin/ssh/ssh-ed25519.c index c03c16346c5..ece438c7ccc 100644 --- a/usr.bin/ssh/ssh-ed25519.c +++ b/usr.bin/ssh/ssh-ed25519.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ssh-ed25519.c,v 1.1 2013/12/06 13:39:49 markus Exp $ */ +/* $OpenBSD: ssh-ed25519.c,v 1.2 2014/02/02 03:44:31 djm Exp $ */ /* * Copyright (c) 2013 Markus Friedl <markus@openbsd.org> * @@ -64,7 +64,7 @@ ssh_ed25519_sign(const Key *key, u_char **sigp, u_int *lenp, memcpy(*sigp, buffer_ptr(&b), len); } buffer_free(&b); - memset(sig, 's', slen); + explicit_bzero(sig, slen); free(sig); return 0; @@ -128,9 +128,9 @@ ssh_ed25519_verify(const Key *key, const u_char *signature, u_int signaturelen, } /* XXX compare 'm' and 'data' ? */ - memset(sigblob, 's', len); - memset(sm, 'S', smlen); - memset(m, 'm', smlen); /* NB. mlen may be invalid if ret != 0 */ + explicit_bzero(sigblob, len); + explicit_bzero(sm, smlen); + explicit_bzero(m, smlen); /* NB. mlen may be invalid if ret != 0 */ free(sigblob); free(sm); free(m); |