summaryrefslogtreecommitdiffstats
path: root/usr.bin/ssh/sshlogin.c
diff options
context:
space:
mode:
authorgilles <gilles@openbsd.org>2007-09-11 15:47:17 +0000
committergilles <gilles@openbsd.org>2007-09-11 15:47:17 +0000
commit4fd6ed324346681d94337dd681df9264591cbde1 (patch)
tree8b58447c8de80075e5d1c091d559e5871db983c0 /usr.bin/ssh/sshlogin.c
parentuse strcspn to properly overwrite '\n' in fgets returned buffer (diff)
downloadwireguard-openbsd-4fd6ed324346681d94337dd681df9264591cbde1.tar.xz
wireguard-openbsd-4fd6ed324346681d94337dd681df9264591cbde1.zip
use strcspn to properly overwrite '\n' in fgets returned buffer
ok pyr@, ray@, millert@, moritz@, chl@
Diffstat (limited to 'usr.bin/ssh/sshlogin.c')
-rw-r--r--usr.bin/ssh/sshlogin.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/usr.bin/ssh/sshlogin.c b/usr.bin/ssh/sshlogin.c
index 44bf5c65331..361562b69e9 100644
--- a/usr.bin/ssh/sshlogin.c
+++ b/usr.bin/ssh/sshlogin.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sshlogin.c,v 1.25 2006/08/03 03:34:42 deraadt Exp $ */
+/* $OpenBSD: sshlogin.c,v 1.26 2007/09/11 15:47:17 gilles Exp $ */
/*
* Author: Tatu Ylonen <ylo@cs.hut.fi>
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -122,8 +122,7 @@ store_lastlog_message(const char *user, uid_t uid)
if (last_login_time != 0) {
time_string = ctime(&last_login_time);
- if (strchr(time_string, '\n'))
- *strchr(time_string, '\n') = '\0';
+ time_string[strcspn(time_string, "\n")] = '\0';
if (strcmp(hostname, "") == 0)
snprintf(buf, sizeof(buf), "Last login: %s\r\n",
time_string);