diff options
| author |   djm <djm@openbsd.org> | 2011-01-11 06:06:09 +0000 |
|---|---|---|
| committer | djm <djm@openbsd.org> | 2011-01-11 06:06:09 +0000 |
| commit | cbf60a62d3f341ada0cc5da136241abe95327387 (patch) | |
| tree | 58e2c8e4fe9336d5d1f59ae53101d3e3667b23e8 /usr.bin/ssh/sshlogin.c | |
| parent | When (cumulative) indentation requested by .in exceeds the right (diff) | |
| download | wireguard-openbsd-cbf60a62d3f341ada0cc5da136241abe95327387.tar.xz wireguard-openbsd-cbf60a62d3f341ada0cc5da136241abe95327387.zip | |
fd leak on error paths; from zinovik@
Diffstat (limited to 'usr.bin/ssh/sshlogin.c')
| -rw-r--r-- | usr.bin/ssh/sshlogin.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/usr.bin/ssh/sshlogin.c b/usr.bin/ssh/sshlogin.c index 361562b69e9..36756a963d8 100644 --- a/usr.bin/ssh/sshlogin.c +++ b/usr.bin/ssh/sshlogin.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sshlogin.c,v 1.26 2007/09/11 15:47:17 gilles Exp $ */ +/* $OpenBSD: sshlogin.c,v 1.27 2011/01/11 06:06:09 djm Exp $ */ /* * Author: Tatu Ylonen <ylo@cs.hut.fi> * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland @@ -86,10 +86,12 @@ get_last_login_time(uid_t uid, const char *logname, r = lseek(fd, pos, SEEK_SET); if (r == -1) { error("%s: lseek: %s", __func__, strerror(errno)); + close(fd); return (0); } if (r != pos) { debug("%s: truncated lastlog", __func__); + close(fd); return (0); } if (read(fd, &ll, sizeof(ll)) != sizeof(ll)) { |