diff options
| author |   deraadt <deraadt@openbsd.org> | 2019-02-13 22:57:07 +0000 |
|---|---|---|
| committer | deraadt <deraadt@openbsd.org> | 2019-02-13 22:57:07 +0000 |
| commit | 915c3f33d30399505d94a06fc5123e4bbdc9531f (patch) | |
| tree | ee3b909e9fc1fb29e610142968bc73a972634746 /usr.sbin/ntpd | |
| parent | sync (diff) | |
| download | wireguard-openbsd-915c3f33d30399505d94a06fc5123e4bbdc9531f.tar.xz wireguard-openbsd-915c3f33d30399505d94a06fc5123e4bbdc9531f.zip | |
(unsigned) means (unsigned int) which on ptrdiff_t or size_t or other
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno
Diffstat (limited to 'usr.sbin/ntpd')
| -rw-r--r-- | usr.sbin/ntpd/parse.y | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/usr.sbin/ntpd/parse.y b/usr.sbin/ntpd/parse.y index be1a7b53699..6b436d55d46 100644 --- a/usr.sbin/ntpd/parse.y +++ b/usr.sbin/ntpd/parse.y @@ -1,4 +1,4 @@ -/* $OpenBSD: parse.y,v 1.70 2018/11/01 00:18:44 sashan Exp $ */ +/* $OpenBSD: parse.y,v 1.71 2019/02/13 22:57:08 deraadt Exp $ */ /* * Copyright (c) 2002, 2003, 2004 Henning Brauer <henning@openbsd.org> @@ -668,7 +668,7 @@ yylex(void) if (c == '-' || isdigit(c)) { do { *p++ = c; - if ((unsigned)(p-buf) >= sizeof(buf)) { + if ((size_t)(p-buf) >= sizeof(buf)) { yyerror("string too long"); return (findeol()); } @@ -707,7 +707,7 @@ nodigits: if (isalnum(c) || c == ':' || c == '_' || c == '*') { do { *p++ = c; - if ((unsigned)(p-buf) >= sizeof(buf)) { + if ((size_t)(p-buf) >= sizeof(buf)) { yyerror("string too long"); return (findeol()); } |