- (void)printf() -> printf(); the cast adds clutter for little value.

- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

1 files changed, 4 insertions, 4 deletions

diff --git a/usr.sbin/tcpdump/print-ospf6.c b/usr.sbin/tcpdump/print-ospf6.c
index a683c01b0e1..9465c1378b6 100644
--- a/usr.sbin/tcpdump/print-ospf6.c
+++ b/usr.sbin/tcpdump/print-ospf6.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: print-ospf6.c,v 1.10 2018/10/22 16:12:45 kn Exp $	*/
+/*	$OpenBSD: print-ospf6.c,v 1.11 2020/01/24 22:46:37 procter Exp $	*/
 
 
 /*
@@ -458,10 +458,10 @@ ospf6_print_lsa(const struct lsa *lsap)
 	}
 
 								/* { (ctags) */
-	fputs(" }", stdout);
+	printf(" }");
 	return (0);
 trunc:
-	fputs(" }", stdout);
+	printf(" }");
 	return (1);
 }
 
@@ -653,5 +653,5 @@ ospf6_print(const u_char *bp, u_int length)
 
 	return;
 trunc:
-	fputs(tstr, stdout);
+	printf("%s", tstr);
 }