summaryrefslogtreecommitdiffstats
path: root/lib/libutil
AgeCommit message (Collapse)AuthorFilesLines
2021-03-31tweak column widths of a .Bl -column tableschwarze1-3/+4
and avoid an over-long source line while here; OK martijn@ jmc@
2021-03-31change the barrier so that fd's are always passed and received witheric1-8/+10
the first byte of the imsg they belong to. idea, tweaks and ok claudio@
2021-03-12fix previousjsg1-2/+2
2021-03-12spellingjsg3-9/+9
2021-03-05Stop abusing display blocks under the authors section in order toanton1-4/+4
respect literal line breaks. This has the unwanted side effect of rendering the authors section using a monospace font over at man.openbsd.org. Instead use br macros to force line breaks. With help from and ok jmc@
2021-03-03s/byte/charactermartijn1-8/+8
Discussed with claudio@ Feedback jmc@
2021-02-22Make the ober_get_* set of function to accept a NULL-pointer.martijn2-16/+55
This allows us to do ber-type checking inside ober_scanf_elements, which will allow for stricter ASN.1 parsing in the future. Manpage feedback and OK claudio@, jmc@ OK claudio@
2021-01-28Add '$' to ober_scanf_elements().martijn2-4/+13
This allows us to enforce end of sequence/set without having to manually check be_next for NULL. No lib bump needed according to millert@ OK millert@ rob@
2021-01-22Gracefully handle any erroneous closing bracket/brace trailers inrob1-2/+2
ober_scanf_elements(). OK martijn@
2021-01-22Valid integer and enumerated types always have non-zero length. Performrob1-1/+5
check to ensure we avoid a possible (undefined) negative shift. Found with clang static analyzer. Tweaked and OK martijn@
2021-01-13Make imsg.h a bit more self-contained by prototyping struct iovec.claudio1-1/+2
OK martijn@ mvs@ deraadt@
2020-12-15typo fix from aisha tammy; ok nicmjmc1-3/+3
2020-10-16double word fixes; from varik valeforjmc1-3/+3
2020-10-12make fixed-sized fixed-value mib[] arrays be constderaadt3-12/+10
ok guenther tb millert
2020-09-04Create ERRORS section for ober_read_elements.martijn1-6/+29
Tweaks and OK tb@ OK jmc@
2020-09-03Missed one case of errno not being set in previous.martijn1-2/+4
double check and OK tb@
2020-09-03Make sure ober_read_elements sets errno on every case where NULL ismartijn1-4/+10
returned. OK deraadt@ tb@
2020-08-02Squelch warning by using idiom from libc bcrypt(3)tb1-2/+2
Clang 10 warns about the expression sizeof(cdata) / sizeof(uint64_t) as cdata is an array of uint32_t and it expects that the intent of this is to compute the number of array elements. Use BCRYPT_WORDS / 2 instead. Same diff as millert's commit sys/lib/libsa/bcrypt_pbkdf.c -r1.2, which was ok kettenis. deraadt confirms that this satisfies clang 10.
2019-12-31Increase BER_MAX_OID_LEN from 32 to 64. Not every snmp OID found in themartijn3-6/+6
wild fits inside 32 elements, like UsmUserEntry objects. OK rob@, claudio@
2019-11-21zero tmpout too. reminded by related diff from timtedu1-1/+2
2019-11-21overwrite the key in failure modes in case the caller doesn't check.tedu2-7/+17
ok deraadt
2019-10-25Adjust whitespace, so Ta macros are aligned vertically as already done intb1-7/+7
ober_add_string.3 and as it was before the ber -> ober rename.
2019-10-24The ber_* namespace is used by liblber since time immemorial,tb10-438/+439
so move our BER API to the unused ober_* prefix to avoid some breakage in ports. Problem diagnosed by jmatthew with ber_free() in samba, but there are many others as pointed out by sthen. tests & ok rob ok sthen (who had an almost identical diff for libutil) "go head hit it" deraadt
2019-08-30uucplock(3) is incorrectly named in some places, it is actually uu_lock(3)deraadt3-6/+6
(more unclear is if anything in ports uses this, as our base no longer does)
2019-08-15Revert previous. There were some users of the quirky behaviour that weremartijn1-2/+2
missed during code scan.
2019-08-14Fix argument list for ber_set_writecallbackmartijn1-3/+5
OK claudio@
2019-08-14wonky comma;jmc1-3/+3
2019-08-14Document that ber_scanf_elements' 'p' and 't' attribute don't eat themartijn1-2/+7
current ber element. OK claudio@ Seems sensible to deraadt@
2019-08-14Make ber_scanf_elements's 'e' attribute eat the element.martijn1-2/+2
Right now all consumers use 'e' at the end of the list, so no regressions should be introduced. OK claudio@ Seems sensible to deraadt@
2019-08-14Make sure that ber in ber_scanf_elements is not NULL before parsing formatmartijn1-3/+3
where ber is utilized. This also allows us to remove the ber->be_next check, which can cause weird behaviour, because a NULL be_next would result in parsing the last element twice. OK claudio@ on previous version OK rob@
2019-08-05Don't use a 0 element to determine the end of an OID when comparing twomartijn1-17/+17
OIDS. This can result in false equality matches. OK claudio@
2019-08-05There's no reason why the first digit of an OID can't be 0.martijn1-4/+1
OK claudio@ "Good find" deraadt@
2019-07-03snprintf/vsnprintf return < 0 on error, rather than -1.deraadt1-7/+9
2019-06-28Actually, the C standard only guarantees that atexit(3) returns non-zeroschwarze1-2/+2
on error, so tweak previous to test "atexit(...) != 0" for portability. "OK ok ok sorry backwards" deraadt@
2019-06-28When system calls indicate an error they return -1, not some arbitraryderaadt8-24/+24
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-28atexit() returns -1 on failurederaadt1-2/+2
2019-06-01Limit maximum number of length octets to platform independent sizeof(int32_t).rob1-2/+5
Problem noticed by bluhm@. Discussed on hackers. ok claudio@
2019-05-21whitespacerob1-2/+2
2019-05-21Cleanup some residual markup from the ber.3 days.rob5-29/+17
ok jmc@, schwarze@
2019-05-17add various missing informationschwarze1-29/+75
and remove the lie that these functions would set errno; tweaks and OK jmc@; OK rob@ on the previous version
2019-05-16Add XXX to a comment.rob1-2/+2
2019-05-16Correct errno markup. Noticed by schwarze.rob2-6/+6
Discussed with schwarze and jmc. ok schwarze
2019-05-15sort SEE ALSO;jmc2-8/+8
2019-05-15add substantial amounts of missing information;schwarze1-24/+96
OK rob@
2019-05-15Consistently make errno a .Vtrob2-6/+8
2019-05-15delete some duplicate wordsschwarze1-4/+2
2019-05-15Split ber.3 into logical parts. Further tweaking will be done in tree.rob7-456/+769
Discussed with and ok jmc@, schwarze@, claudio@
2019-05-12Enable support for the writting of BITSTRING by treating it as an OCTETSTRING.rob1-2/+1
ok claudio@
2019-05-12Enforce smallest number of contents octets for int (and enum).rob1-2/+9
ok claudio@
2019-05-12Mention #include of <sys/types.h> in synopsis.rob1-2/+3
Discussed with claudio@ and tedu@.