| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
member of 'struct scsi_xfer' has always been pointed at the 'struct scsi_generic
cmdstore' member of the same instance. So nuke 'cmdstore' and remove the '*'
from cmd. Take the address of cmd as required by the various casts.
No intentional functional change.
luna88k test by aoyama@, sparc64 test by jmatthew@
Identification of 2009's last *cmd use and ok jmatthew@
|
|
|
|
|
|
|
|
| |
rarely (if ever) been done.
Fix many printf format errors to calm clang and gcc on amd64, i386,
hppa. Missing #include, complaints if 'option <blah>DEBUG' is used in
config files, etc. All in debug code.
|
|
|
|
|
|
|
| |
fields to struct scsibus_attach_args. Nuke the struct scsi_link *
(saa_sc_link) in scaibus_attach_args.
Explicitly initialize each field in scsibus_attach_args variables.
|
|
|
|
|
|
|
| |
adapter_buswidth, adapter_softc) from struct scsi_link to struct
scsibus_attach_args.
Additional compile tests by jmatthew@ (sparc64) and aoyam@ (luna88k).
|
|
|
|
|
|
|
|
| |
In sparc64 autoconf access 'luns' via sb_luns and 'adapter_buswidth'
via sb_adapter_buswidth.
Removes last post-config uses of the copies of bus related
information in scsi_link.
|
|
|
|
| |
statement. All to make upcoming diff(s) smaller and easier to read.
|
|
|
|
| |
immediately before initializing the only field in the struct.
|
|
|
|
|
|
|
| |
aassigned to adapter_buswidth to indicate the adapter is not a target
on the bus.
ok dlg@ as part of a larger diff.
|
|
|
|
|
|
|
|
| |
nothing at all. MAXPHYS will be applied in minphys() and nothing at
all, well, doesn't do anything.
Also remove any '#define <blah> MAXPHYS' statements used solely to
disguise MAXPHYS in said functions.
|
|
|
|
|
|
|
|
| |
inducing. Rename scsi_adapter member 'scsi_minphys' to 'dev_minphys'
to reflect what it is supposed to do. Use consistent naming convention
(<dev>_minphys) for the actual device functions.
No functional change.
|
|
|
|
|
|
|
| |
system minphys(). scsi_minphys() will do that and cd/sd/st will call
scsi_minphys().
ok jmatthew@ as part of larger diff
|
|
|
|
|
|
|
|
|
|
|
| |
"i" is a count of milliseconds. We convert it to a starting interval
"ts" and determine our absolute timeout "end". Then we loop through
until the poll is successful or "end" elapses.
This could be simplified with an absolute timeout interface for
tsleep(9) but alas, we don't have one yet.
ok krw@
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are really two loops here. One for SCSI_NOSLEEP and delay(9),
the other for tsleep(9). The paths share a loop in the code but they
shouldn't. They have different termination conditions and share little
code.
If we pull the conditional clause out of the for-loop and then give each
path its own polling loop the logic should be easier to follow.
ok krw@
|
|
|
|
|
|
| |
Should make untangling the polling logic simpler.
"Sure." krw@
|
|
|
|
|
|
| |
drivers that fill that field in too.
quad types are going away.
|
| |
|
|
|
|
| |
ok krw@
|
|
|
|
|
|
|
| |
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.
ok tedu@ deraadt@
|
|
|
|
| |
ok mpi@ kspillner@
|
|
|
|
| |
ok tedu
|
|
|
|
| |
after discussions with beck deraadt kettenis.
|
|
|
|
|
|
| |
cleaning up some shutdown-hook related code on the way.
(A few drivers related to sparc are still skipped at kettenis' request)
ok kettenis mlarkin, tested by many others too
|
| |
|
|
|
|
|
|
| |
is causing problems when trying to boot sparc64 from an isp(4).
Verified to fix the sparc64/isp(4) regression by krw@; ok deraadt@
|
|
|
|
|
|
| |
saa_luns instead of adapter_buswidth and luns in the prototype link.
ok dlg@, miod@
|
|
|
|
| |
"reads OK" claudio@
|
|
|
|
| |
ok dlg@ matthew@
|
|
|
|
|
|
|
|
|
|
|
|
| |
to sync the map. unfortunately xs is not set for internal ciss
commands, so this is a null deref. it wasnt until kettenis made
bus_dmamap_sync a real function which needed its arguments evaluated
that this became a real problem though.
hit by mcbride@ and sakurai-san. fixed by krw@ over my shoulder
when we figured out which specific chunk of code was faulting.
tested by sakurai-san
ok krw@ deraadt@
|
|
|
|
|
|
|
| |
iopools make sure resources arent overallocated, while scheduling them
evenly between devices.
tested by and ok jsg@
|
|
|
|
|
|
| |
sensor_attach() out of the for loop header.
ok marco@
|
| |
|
|
|
|
|
|
| |
sparsely populated buses.
ok dlg@, krw@
|
|
|
|
|
|
|
|
| |
step in elminating 'struct scsi_device' entirely.
Spotted and initial diff from matthew@.
ok matthew@ dlg@ deraadt@ marco@ miod@
|
|
|
|
|
|
| |
must break out of the cases, not directly 'return' error codes. I
think the error case is currently impossible, but why leave an armed
bear trap lying about?
|
|
|
|
|
|
|
| |
ioctl requests, and dont pass the proc pointers around for any ioctl
requests in scsi land at all. neither were used, so trim the fat.
ok krw@ marco@
|
|
|
|
| |
pointed out by brad.
|
| |
|
|
|
|
| |
dont typedef the tailq head struct.
|
|
|
|
|
|
|
|
|
|
| |
tweaks ive made.
this provides better concurrent access to multiple volumes on the same hba,
while improving the reliability of the ioctl and sensor codepaths.
tested by okan@ halex@
ok krw@ okan@ halex@
|
|
|
|
| |
especially if you're passing it SCSI_POLL too.
|
|
|
|
| |
for us.
|
|
|
|
| |
scsi_done or to get or put ccbs anymore.
|
| |
|
|
|
|
|
| |
state as such, putting it on a queue is silly. one of the queues was
initted by never used.
|
|
|
|
| |
confuses the code and bloats the kernel.
|
|
|
|
|
| |
in a disk controllers handler, even if it has a useless bunch of macros
around it.
|
|
|
|
|
|
| |
keep count for at least 33 seconds. then panic.
ok marco@, moral support johan@
|
|
|
|
| |
ok krw@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
void. Use XS_NO_CCB error in the scsi command (xs) to report the
NO_CCB condition. Eliminates all SUCCESSFULLY_QUEUED and COMPLETE
confusion and untangles the midlayer from the adapter a bit more.
Eyes and some fixes by miod@
There may be some compile issues on little used (i.e. I don't have
any) drivers but the change is mechanical and thus easy to remedy.
ok dlg@
|
|
|
|
|
|
|
| |
else cares so it's just noise. Drivers that actually look at ITSDONE
are unchanged.
ok marco@ (for his files) dlg@ beck@
|