summaryrefslogtreecommitdiffstats
path: root/sys/dev/ic/fxp.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.patrick2020-07-101-3/+3
| | | | ok dlg@ tobhe@
* move counting if_opackets next to counting if_obytes in if_enqueue.dlg2017-01-221-2/+1
| | | | | | | this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it. ok mpi@ deraadt@
* G/C IFQ_SET_READY().mpi2016-04-131-2/+1
|
* Rewrite the tx handler to just use ifq_dequeue and drop packets thatclaudio2015-12-031-13/+15
| | | | | could not be sent either because the dma mapping failed or because m_defrag failed. Those errors are accounted as oerrors. dlg@ agrees.
* Simplify fxp tx dma handling by using m_defrag instead of rolling our ownclaudio2015-12-021-29/+13
| | | | | version. Based on a very old diff from brad@, tested by me and David Hill OK kettenis@
* replace IFF_OACTIVE manipulation with mpsafe operations.dlg2015-11-251-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue is now protected by a mutex. this diff makes the oactive functionality mpsafe too. IFF_OACTIVE is part of if_flags. there are two problems with that. firstly, if_flags is a short and we dont have any MI atomic operations to manipulate a short. secondly, while we could make the IFF_OACTIVE operates mpsafe, all changes to other flags would have to be made safe at the same time, otherwise a read-modify-write cycle on their updates could clobber the oactive change. instead, this moves the oactive mark into struct ifqueue and provides an API for changing it. there's ifq_set_oactive, ifq_clr_oactive, and ifq_is_oactive. these are modelled on ifsq_set_oactive, ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd. this diff includes changes to all the drivers manipulating IFF_OACTIVE to now use the ifsq_{set,clr_is}_oactive API too. ok kettenis@ mpi@ jmatthew@ deraadt@
* You need <netinet/ip.h> if you use "struct ip" for hw checksum.mpi2015-11-241-2/+1
| | | | You never need <netinet/ip_var.h> nor <netinet/in_systm.h>.
* The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.mpi2015-11-241-2/+1
|
* shuffle struct ifqueue so in flight mbufs are protected by a mutex.dlg2015-11-201-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the code is refactored so the IFQ macros call newly implemented ifq functions. the ifq code is split so each discipline (priq and hfsc in our case) is an opaque set of operations that the common ifq code can call. the common code does the locking, accounting (ifq_len manipulation), and freeing of the mbuf if the disciplines enqueue function rejects it. theyre kind of like bufqs in the block layer with their fifo and nscan disciplines. the new api also supports atomic switching of disciplines at runtime. the hfsc setup in pf_ioctl.c has been tweaked to build a complete hfsc_if structure which it attaches to the send queue in a single operation, rather than attaching to the interface up front and building up a list of queues. the send queue is now mutexed, which raises the expectation that packets can be enqueued or purged on one cpu while another cpu is dequeueing them in a driver for transmission. a lot of drivers use IFQ_POLL to peek at an mbuf and attempt to fit it on the ring before committing to it with a later IFQ_DEQUEUE operation. if the mbuf gets freed in between the POLL and DEQUEUE operations, fireworks will ensue. to avoid this, the ifq api introduces ifq_deq_begin, ifq_deq_rollback, and ifq_deq_commit. ifq_deq_begin allows a driver to take the ifq mutex and get a reference to the mbuf they wish to try and tx. if there's space, they can ifq_deq_commit it to remove the mbuf and release the mutex. if there's no space, ifq_deq_rollback simply releases the mutex. this api was developed to make updating the drivers using IFQ_POLL easy, instead of having to do significant semantic changes to avoid POLL that we cannot test on all the hardware. the common code has been tested pretty hard, and all the driver modifications are straightforward except for de(4). if that breaks it can be dealt with later. ok mpi@ jmatthew@
* arp_ifinit() is no longer needed.mpi2015-10-251-4/+1
|
* firmware sizes are known; use them for free()deraadt2015-08-291-2/+2
|
* Increment if_ipackets in if_input().mpi2015-06-241-2/+1
| | | | | | | Note that pseudo-drivers not using if_input() are not affected by this conversion. ok mikeb@, kettenis@, claudio@, dlg@
* Remove some includes include-what-you-use claims don'tjsg2015-03-141-2/+1
| | | | | | | have any direct symbols used. Tested for indirect use by compiling amd64/i386/sparc64 kernels. ok tedu@ deraadt@
* Convert to if_input().mpi2015-02-121-10/+7
| | | | ok dlg@
* unifdef INETtedu2014-12-221-5/+1
|
* Fewer <netinet/in_systm.h>mpi2014-07-221-2/+1
|
* add a size argument to free. will be used soon, but for now default to 0.tedu2014-07-121-2/+2
| | | | after discussions with beck deraadt kettenis.
* The few network drivers that called their children's (ie. mii PHYderaadt2013-12-281-2/+1
| | | | | drivers) activate functions at DVACT_RESUME time do not need to do so, since their PHYs are repaired by IFF_UP.
* Add a DVACT_WAKEUP op to the *_activate() API. This is called after thederaadt2013-12-061-12/+7
| | | | | | | | kernel resumes normal (non-cold, able to run processes, etc) operation. Previously we were relying on specific DVACT_RESUME op's in drivers creating callback/threads themselves, but that has become too common, indicating the need for a built-in mechanism. ok dlg kettenis, tested by a sufficient amount of people
* replace workqs with tasks for handling resumedlg2013-11-141-4/+5
| | | | from kimberley manning
* Most network drivers include netinet/in_var.h, but apparently theybluhm2013-08-071-2/+1
| | | | | don't have to. Just remove these include lines. Compiled on amd64 i386 sparc64; OK henning@ mikeb@
* Avoid potential uninitialized variable access in fxp driver.blambert2012-10-101-4/+4
| | | | | | Found by haesbaert@. ok haesbaert@ deraadt@
* After suspend/resume, reload the firmware. Skip firmware onderaadt2012-04-031-21/+49
| | | | FXP_REV_82550_C with server extensions.
* fxp_init could bail out on errors without calling slpx.mpf2011-12-191-4/+7
| | | | | Change fxp_resume to avoid the nested splnet call inside fxp_init altogether. Initial diff by Jan Klemkow; Tested and OK bluhm.
* Do not use NULL in integer comparisons. No functional change.miod2011-04-071-2/+2
| | | | ok matthew@ tedu@, also eyeballed by at least krw@ oga@ kettenis@ jsg@
* remove the powerhook code. All architectures now use the ca_activate treederaadt2010-09-071-19/+1
| | | | | traversal code to suspend/resume ok oga kettenis blambert
* initialize rv to 0 in the activate functionderaadt2010-09-061-2/+2
|
* Add DVACT_QUIECE support. This is called before splhigh() and beforederaadt2010-08-311-1/+4
| | | | | | | | DVACT_SUSPEND, therefore DVACT_QUIECE can do standard sleeping operations to get ready. Discussed quite a while back with kettenis and jakemsr, oga suddenly needed it as well and wrote half of it, so it was time to finish it. proofread by miod.
* activate function should return result of config_activate_childrenderaadt2010-08-311-4/+5
|
* Since the pci-specific activate function does nothing, move it to fxp.c.deraadt2010-08-271-22/+35
| | | | Then it is possible for fxp_powerhook to use it.
* ca_activate for suspend/resume; tested by andrew@afresh1.comderaadt2010-08-061-3/+1
|
* BUS_DMA_ZERO instead of alloc, map, bzero.oga2010-05-191-3/+3
| | | | ok krw@
* Add detach support to a few more drivers, and in others do the neccessaryderaadt2009-10-151-18/+20
| | | | | | operations in the detach function in the right order. Also ensure that the interrupt handlers not trust registers that go away. read over very carefully by dms, tested by me
* Don't setup multicast when in promiscuous mode. From Brad.sthen2009-08-251-10/+14
| | | | | | | This was in the diff Brad sent to tech@ and had tested by others and should have been in my previous commit, but I was working from and testing an earlier version of the diff. I've retested with multicast/promisc on my dual 82550.
* Rewrite part of the promiscuous/multicast handling; tested by myself,sthen2009-08-131-18/+10
| | | | naddy@ and several tech@ readers. From Brad.
* More cases of shutdown hooks not needed after card is already stopped. Inderaadt2009-08-101-25/+6
| | | | | | these cases the xxstop function is a bit more complicated and has a flag of some sort, but the use of that flag does not matter; DMA is already ceased ok dlg
* Rewrite the SIOCSIFFLAGS ioctl handling code to clean it up a bit andnaddy2009-06-061-11/+10
| | | | make it consistent with other drivers. No functional change. From Brad.
* Make fxp at pci detachable; untested.jsg2009-06-021-1/+27
|
* Eliminate the redundant bits of code for MTU and multicast handlingbrad2008-11-281-24/+7
| | | | | | | | | | | | | | from the individual drivers now that ether_ioctl() handles this. Shrinks the i386 kernels by.. RAMDISK - 2176 bytes RAMDISKB - 1504 bytes RAMDISKC - 736 bytes Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users. Build tested on almost all archs by todd@/brad@ ok naddy@
* First step towards cleaning up the Ethernet driver ioctl handling.brad2008-10-021-7/+3
| | | | | | | | | | | | | | | | | | | | Move calling ether_ioctl() from the top of the ioctl function, which at the moment does absolutely nothing, to the default switch case. Thus allowing drivers to define their own ioctl handlers and then falling back on ether_ioctl(). The only functional change this results in at the moment is having all Ethernet drivers returning the proper errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown ioctl's. Shrinks the i386 kernels by.. RAMDISK - 1024 bytes RAMDISKB - 1120 bytes RAMDISKC - 832 bytes Tested by martin@/jsing@/todd@/brad@ Build tested on almost all archs by todd@/brad@ ok jsing@
* Convert timeout_add() calls using multiples of hz to timeout_add_sec()blambert2008-09-101-3/+3
| | | | | | | Really just the low-hanging fruit of (hopefully) forthcoming timeout conversions. ok art@, krw@
* Some fxp(4) chips do not like having their status/command registers accessedbrad2008-02-211-21/+56
| | | | | | | | | | | as 8-bit reads/writes even though they are 16-bit. This can cause the respective interfaces to lock up until the system is hard rebooted. Having the driver read/write to these registers as 16-bit entities resolves the instability. From mickey@ ok krw@ sthen@ dlg@
* - Only clear the IFF_OACTIVE flag if packets were processed.brad2008-02-201-4/+6
| | | | | | | | | | | - Only clear the watchdog timer if there are no more packets to process otherwise rearm the timer. From mickey@ Tested by krw@, mikeb@ and brad@ ok dlg@
* remove unneeded declarations that shadows existing vars; ok by many.fgsch2007-10-131-2/+1
|
* new format firmware load messagederaadt2007-08-311-3/+3
|
* do not include ipx headers (were not needed in the first place)henning2007-06-061-6/+1
|
* put more foo_detach() routines where they are usedderaadt2007-05-081-27/+1
|
* Add missing "goto fail;" in an error path of fxp_attach().claudio2007-03-161-1/+2
|
* Don't re-initialize the card every time the IP address is changed.krw2006-12-261-10/+4
| | | | | | | | | Brings fxp into line with many other drivers. From brad@, tested by martin@, thib@, pyr@, mk@ and Johan M:son Lindman. ok martin@
* insufficient testing, martin, please do not be a moronderaadt2006-12-131-4/+10
|