| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Fine deraadt@
|
|
|
|
| |
From kristaps@
|
|
|
|
|
|
| |
inactivity. By default rsync will wait forever but this results in stuck
processes if the remote side does not answer properly as seen in rpki-client.
OK job@ benno@
|
|
|
|
|
|
| |
occasionally for fatal source-code bugs are critical and must be hunted down.
It is NOT suitable to expose regular users to this on a regular basis though.
ok kn beck
|
|
|
|
|
| |
when connecting to a rsync daemon.
OK deraadt@ benno@ naddy@ sthen@
|
|
|
|
|
|
| |
a rolling computation for the fast-hash.OB With this openrsync is on
par with gpl rsync for file updates.
From kristaps
|
|
|
|
|
| |
functions.
ok deraadt@
|
| |
|
|
|
|
|
|
|
|
|
| |
and behaviour is the same as GPL rsync.
Initial diff received feedback from benno@, schwarze@, deraadt@ and
florian@. Thanks!
OK deraadt@
|
|
|
|
|
| |
composition code for the remote process.
ok florian naddy
|
|
|
|
|
| |
in the io-path, whic is done by seperating int vs uint functions variants.
reviewed by naddy, florian, and jsg
|
|
|
|
|
|
|
|
|
|
|
| |
into two functions, rsync_connect() to establish a TCP connection
to the remote daemon, and rsync_socket() to run the actual protocol.
E.g.:
rsync -av --del -e 'ssh -W localhost:rsync -lanoncvs' \
rsync://anoncvs.spacehopper.org/OpenBSD-CVS/ /cvs
ok deraadt@
|
|
|
|
|
| |
so they don't need to be constructed to return errors.
ok benno florian
|
|
|
|
|
|
| |
read by a C++ compiler, and __* are no lonmger recommended.
https://www.gnu.org/software/libtool/manual/html_node/C-header-files.html
ok deraadt@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.
baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.
821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@
6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string
4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.
f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.
e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.
c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.
93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.
baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments. Add
common -av usage. Remove bits about not supporting anything but
files/dirs.
821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@
6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string
4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM. From deraadt@. Tweaked for lowercase messages.
f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller. Also keep the original line lengths. While in mktemp.c, make
some defines into an enum.
e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function. Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.
c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking. This frees us of deadlocking the protocol because
the sender will always be able to pull down data.
93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD. Most found by deraadt@.
|
|
|
|
|
| |
real rsync only supports numbers, but this supports service names also
ok florian benno
|
| |
|
| |
|
|
|
|
| |
Remove spaces at end of line.
|
|
|
|
|
|
| |
Make sender mostly nonblocking for writes. This takes a lot of logic once
in blocks.c and puts it directly into sender.c. It allows running openrsync
against itself without deadlocks.
|
|
|
|
|
|
| |
Make sender have reentrant sending and prioritised reading. This way,
the sender gets data off the wire as quickly as possible. While here,
remove dead wood from blocks.c (blk_merge).
|
|
|
|
| |
"you snooze, you get collisions" deraadt@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mkstempat() works exactly like mkstemp(3) except that it replaces
open(2) with openat(2) so that it can be used in rsync_downloader()
to easily deal with relative paths.
mkstemplinkat() works somewhat like mkdtemp() to create a template
symlink.
Use the mkstemplinkat() to create or update symlinks and overwrite
existing objects including empty directories that might exist under
the destination name.
"you snooze, you get collisions" deraadt@
|
|
|
|
|
| |
Put permission-setting code into its own function, as we'll need to call it
from several places. Also enable that -o sets the owner.
|
|
|
|
|
|
|
| |
Protocol-level support for -o. The actual sharing itself is more or less a
copy of the existing -g code. I've refactored a lot of the ids.c code to be
generic and only accept a "isgid", as the rest is the same. So there's some
churn as I make all references to "group" be generic.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
commit 72ea211d57a0f235a2d7439a7e908af66f47fa10
Author: kristaps <>
Date: Tue Feb 12 07:29:55 2019 +0000
Sanitise group handling to handle group wheel (according to rsync, this is not
ever remapped by name) and empty group names (not allowed, but we must accept them
anyway). Push most of this code into ids.c and make sure it is style(9)
conformant. Add TODO about performance and clarify protocol in rsync.5.
|
|
|
|
|
|
|
|
| |
commit bc997c5d70dbe402903c7ce0c915c7fe3744a754
Author: kristaps <>
Date: Mon Feb 11 23:37:41 2019 +0000
Move identifier code into ids.c.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit b55c5ce631d8fd557d665e25e31191b33c15f829
Author: kristaps <>
Date: Mon Feb 11 23:27:23 2019 +0000
Pass down -g and also order flags.
and the extern.h chunk from
commit 472ad2fab2692579a5773d78d6934b03c1098fb2
Author: kristaps <>
Date: Mon Feb 11 20:45:22 2019 +0000
|
|
|
|
| |
ok florian benno
|
|
|
|
|
| |
a false perception of safety
ok benno florian
|
| |
|
|
OK deraadt@
|