summaryrefslogtreecommitdiffstats
path: root/usr.bin/sendbug/sendbug.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Use waitpid()/EINTR idiom for the specific pid, rather than generic wait(),deraadt2017-08-211-4/+9
| | | | | | | | in case the parent process was started with a dangling child. This style ensures any potential parent:child interlock isn't disrupted due to the "wrong" child being waited on first. Then the other other childs can safely zombie. ok millert jca brynet
* Use the files in /var/db/acpi instead of trying to run acpidump.kettenis2016-10-181-7/+3
| | | | ok brynet@
* Also print a warning if the user doesn't fill the mail Subjectjca2016-05-181-3/+7
| | | | Alternative diff by Tim (trondd ! kagu-tsuchi . com), ok tedu@
* Print a user-friendly message if some fields are missing; ok tedu@jca2016-05-181-7/+13
|
* Last parameter to execl[e]() functions *must* be cast to a pointer.krw2016-03-171-2/+2
| | | | | | | | | | | | Just NULL is not good practise as NULL is theoretically allowed to be an integer rather than a pointer. Use (char *)NULL consistently instead of scattering a few (char *)0 and (void *)NULL into the mix. Prompted by and probably ok deraadt@ millert@ kettenis@ Definitely ok mestre@ ratchov@
* remove TMPDIR supportderaadt2015-10-261-5/+2
|
* -version options on commands like this make no sense; the version numberderaadt2015-10-111-7/+3
| | | | | makes no promises about compatibility nor the lack of compatibility. suggestion & diff from micheal reed
* normalize a few more tame request orderings, to help reviewderaadt2015-10-101-2/+2
|
* pledge "stdio getpw rpath wpath cpath tmppath proc exec". doug pointed outderaadt2015-10-101-1/+4
| | | | | the need for getpw. Not sure if I see ways to improve this program. ok doug
* Replace <sys/param.h> with <limits.h> and other less dirty headers wherederaadt2015-01-161-2/+1
| | | | | | | | | possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
* Retire hp300, mvme68k and mvme88k ports. These ports have no users, keepingmiod2014-03-181-3/+3
| | | | | | | this hardware alive is becoming increasingly difficult, and I should heed the message sent by the three disks which have died on me over the last few days. Noone sane will mourn these ports anyway. So long, and thanks for the fish.
* Have sendbug(1) submit error reports to bugs@, instead of gnats@.phessler2012-07-211-2/+2
| | | | OK deraadt@
* Fix some pclose() calls, spotted by Peter Philipp. ok deraadt@sthen2010-04-201-5/+3
|
* Include usbdevs -v output in the PR template, showing us device IDs whichsthen2010-04-201-5/+28
| | | | cannot be deduced from the dmesg output. Suggested by miod@, ok deraadt@
* fixes memory and FILE handle leaks. `acpidir' is allocated viaderaadt2010-03-231-1/+3
| | | | | asprintf(3) and `ifp' is opened via popen(3), but not closed. from zinovik
* initialize tmpdir before use; PR 6214deraadt2009-08-261-3/+4
|
* Remove gecos expanding code, since the expanded string is no longerray2009-06-071-38/+4
| | | | used.
* Include pcidump and acpidump output when sendbug is run as root,ray2009-06-061-9/+90
| | | | | | | | | to aid ACPI development. Output files are base64 encoded in the report. Add a -E flag to decode files from a report to the current directory. Requested by deraadt, "Sweet!" marco, "Looks good to me." pirofti
* Re-add "Category" category to sendbug template. Without it, reportsray2009-01-281-10/+19
| | | | | | were categorized as "pending" and the report was never acked. Reported by RD Thrush and bernd@, OK miod
* Remove useless fields from template, they just serve to confuseray2008-12-141-51/+12
| | | | | | users. Idea okayed by art and deraadt, feedback from jmc.
* parse all arguments before going and doing the job requested by -Pderaadt2008-10-061-5/+10
| | | | | (slight change made to check argc == 0) from Daniel Dickman
* - remove ports category after discussion w/ manypvalchev2008-06-141-3/+3
| | | | | - sync architectures list with reality and fix a few names ok theo
* replace "/usr/sbin/sendmail" with _PATH_SENDMAILchl2008-05-081-2/+2
| | | | | | | | no binary change found by Daniel Dickman <didickman at gmail.com> ok ray@
* Decrement len variable after removing newline, prevents copying theray2008-04-191-5/+7
| | | | | | | | | | NUL at the end of a string into the mail. Discovered by dasn. Move newline printing into outer loop, prevents multiple newlines from appearing if there are multiple comments in a line. Discovered by okan. OK okan.
* Eliminate false positives from <> comments, avoiding manglingray2008-01-041-27/+38
| | | | | | | | | | | #include <bleh.h> in diffs: - Only match <> comments from the template. No other text surrounded by angle brackets is deleted. - Simplify code by using C strings. We no longer handle binary data, but I don't think binary data belongs in a bug report anyway. - Remove dmesg and header comment checks. "That's a nice approach." deraadt, "seems ok for me" chl.
* In preparation of eliminating <> comment false positives:ray2008-01-031-23/+31
| | | | | | | | - Move <> comments in template to an array, for easier reference later. - Rename "comment" variable to avoid shadowing. - Change some <> comments to SENDBUG comments. OK chl@
* - Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) byderaadt2007-10-171-12/+9
| | | | | | | | temporarily restoring default behaviour. This is not 100% ideal. But this fixes editor handling in mail... bah, it is really unfortunate that got broken - refactor the restoration code as well, to make it simpler ok ray
* Don't treat lines in angle brackets <...> as comments in dmesg.ray2007-09-181-7/+15
| | | | Discovered and tested by deanna.
* Remove some unused headers, from Igor Zinovik.ray2007-07-311-2/+1
|
* If fork fails with EAGAIN, ignore errno and fail. Looping justray2007-05-111-6/+3
| | | | | | worsens the problem. cloder@ and deraadt@ agree.
* Instead of returning -1 and setting errno to ECHILD if the editorray2007-05-111-5/+11
| | | | | | has a non-zero exit status, just return the exit status on success. Hard errors still return -1. If the editor is killed, return -1 and set EINTR.
* Be more consistent about when dmesg is attached to template.ray2007-05-091-7/+7
| | | | Specifically, -V.
* Simplify some loops.ray2007-05-071-28/+17
| | | | OK jaredy@ and moritz@.
* Restore signals before returning.ray2007-05-061-4/+10
|
* Save and restore signals once instead of each time fork fails withray2007-05-061-5/+5
| | | | EAGAIN.
* Remove extra code that only applies to setuid/setgid programs.ray2007-04-251-5/+3
| | | | ``Slacker! We'll burn your hands if you don't get going!'' deraadt@
* Sprinkle const poison, remove unneeded variable.ray2007-04-071-6/+5
|
* Use __progname and warn instead of fprintf where appropriate.ray2007-04-071-5/+6
|
* De-lint.ray2007-04-071-4/+5
|
* Warn if one of the required fields is not filled out. Requestedray2007-04-061-1/+74
| | | | by millert@.
* Don't shadow variables. Enable -Wshadow.ray2007-04-061-10/+10
|
* argc does not include __progname after subtracting optind.ray2007-04-061-2/+2
|
* Only include newest dmesg.ray2007-04-061-25/+47
| | | | ``Come on, take some risks'' deraadt@.
* Attach dmesg to sendbug reports by default. Use -D flag to disable.ray2007-04-061-7/+38
| | | | OK deraadt@ and millert@.
* CC: a copy of the bug report to sender. Requested by Travers Buda.ray2007-03-281-2/+2
| | | | OK millert@.
* Replace some scary pointer code. The new code is O(n^2) for stringsray2007-03-271-24/+29
| | | | | | | | of '&', but gecos fields are usually short and most do not have '&' so the impact should be minimal. In return we get clearer and safer code. OK moritz@.
* Remove variable name from prototype.ray2007-03-271-2/+2
|
* Simplify gecos parsing code and prevent buffer overflowmoritz2007-03-261-12/+8
| | | | | | | when gecos field contains multiple '&' characters with other characters inbetween. With and OK ray@
* Remove pointless cast. No binary change.ray2007-03-261-2/+2
|
* Break on waitpid success; we shouldn't continue on WIFSIGNALED, andray2007-03-261-2/+2
| | | | | | WIFCONTINUED can't happen in this case. OK deraadt@.
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.